Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Lock Reason Display for Interface #507

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

zeng-github01
Copy link

@zeng-github01 zeng-github01 commented Nov 8, 2024

image

@zeng-github01
Copy link
Author

@NotMyWing After investigation, the existing AE2UEL cannot obtain UnlockStack, and a new Packct needs to be added and backported from modern AE2. Do you think it is necessary to implement this? Or should it continue to display "waiting for pattern output"?

@NotMyWing
Copy link
Member

A packet should be fine for now. In future, we could figure out a better solution that might also allow people to track which interfaces exactly are stuck waiting on products.

@zeng-github01
Copy link
Author

zeng-github01 commented Dec 1, 2024

A packet should be fine for now. In future, we could figure out a better solution that might also allow people to track which interfaces exactly are stuck waiting on products.

The existing problem is that the @GuiSync annotation related to the SyncData class cannot support AEItemStack, resulting in the inability to pass data to the Client and the inability to display what items are being waited for.

To be honest, this is very difficult to backport, I am already stuck here

Is there any better solution?

There is another problem. The existing GuiInterface has poor arrangement of elements, which always feels a bit inconsistent. Can you try fine-tuning it?

Do the existing content need to be merged before being released?

@zeng-github01 zeng-github01 marked this pull request as draft December 3, 2024 02:16
@zeng-github01
Copy link
Author

A bug in the first part of the patch was found in Issue. It will be fixed here as well.

@zeng-github01 zeng-github01 marked this pull request as ready for review December 3, 2024 12:29
@zeng-github01
Copy link
Author

@NotMyWing Please review and merge as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants